Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Review limit reached
More reviews will be available in 9 minutes and 40 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughNormalize GitHub Actions and pre-commit YAML formatting, consolidate build dependency installs, reformat CodeQL steps, update pre-commit hooks (add mdformat/yamlfmt, remove mirrors-prettier), collapse .clang-tidy checks, reorder CHANGELOG links, and apply multiple Markdown formatting edits across README/USAGE/src README. ChangesCI, pre-commit, lint, and docs reformat
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 196: Typo in README: replace the misspelled "arists'" with the correct
"artists'" in the documentation (search for the string "arists'" and update it
to "artists'") so the possessive of artist is spelled correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 102b1c0a-0d14-4c1e-8cbc-51a3690a8a2f
📒 Files selected for processing (9)
.clang-tidy.github/workflows/build.yml.github/workflows/codeql.yml.github/workflows/pre-commit.yml.pre-commit-config.yamlCHANGELOG.mdREADME.mdUSAGE.mdsrc/README.md
💤 Files with no reviewable changes (3)
- .github/workflows/pre-commit.yml
- .github/workflows/codeql.yml
- .github/workflows/build.yml
✅ Files skipped from review due to trivial changes (3)
- .clang-tidy
- USAGE.md
- CHANGELOG.md
fangfufu
changed the title
- Replace legacy prettier hook with executablebooks/mdformat for Markdown. - Add google/yamlfmt to format all YAML config and workflow files. - Add mdformat-gfm-alerts to natively support GitHub Alerts syntax at 80-char wrap. - Remove obsolete prettier-ignore comments and apply formatting repo-wide.
- Format local pre-commit hook commands into clean, multiline literal block scripts. - Shorten PKG_CONFIG_PATH definition in build.yml to be defined incrementally.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
7-8: ⚡ Quick winAdd a least-privilege
permissionsblock.This workflow defines no
permissions, so jobs run with the default (broad)GITHUB_TOKENscope. Unlikecodeql.yml, which scopes permissions per job,build-macandbuild-ubuntuonly read the repo and upload artifacts, so a read-only token suffices. (Flagged by zizmor:excessive-permissions.)🛡️ Suggested top-level permissions
jobs: +permissions: + contents: read + +jobs: build-mac:Note: place the
permissionskey at the workflow top level (beforejobs:), not inside it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build.yml around lines 7 - 8, Add a top-level permissions block (placed before the jobs: key) to restrict the GITHUB_TOKEN to least privilege; for this workflow that only reads the repo and uploads artifacts, set permissions: contents: read and actions: write so build-mac and build-ubuntu no longer run with the default broad token.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 44-46: The README's fenced code blocks are missing language
identifiers (causing MD040); update each triple-backtick block examples (e.g.,
lines showing commands like "./httpdirfs -f --cache $URL $MOUNT_POINT" and other
CLI examples) to include an explicit language tag such as bash (or text where
appropriate). Search for all code blocks referenced in the comment (sections
around the shown ranges) and prepend the opening ``` with ```bash (or ```text
for non-shell output) so markdown linting passes.
- Around line 299-300: Fix the grammar in the README sentence that currently
reads "this program parse" by changing it to "this program parses" so the verb
agrees with the singular subject; locate the sentence containing "this program
parse" (the technical details paragraph referencing Gumbo parser and sonic
servers' XML responses) and update the phrase to "this program parses".
---
Nitpick comments:
In @.github/workflows/build.yml:
- Around line 7-8: Add a top-level permissions block (placed before the jobs:
key) to restrict the GITHUB_TOKEN to least privilege; for this workflow that
only reads the repo and uploads artifacts, set permissions: contents: read and
actions: write so build-mac and build-ubuntu no longer run with the default
broad token.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 91b3f5f1-ff72-40e6-b492-71a311340081
📒 Files selected for processing (9)
.clang-tidy.github/workflows/build.yml.github/workflows/codeql.yml.github/workflows/pre-commit.yml.pre-commit-config.yamlCHANGELOG.mdREADME.mdUSAGE.mdsrc/README.md
✅ Files skipped from review due to trivial changes (4)
- USAGE.md
- CHANGELOG.md
- .clang-tidy
- src/README.md
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/pre-commit.yml
- .pre-commit-config.yaml
| ``` | ||
| ./httpdirfs -f --cache $URL $MOUNT_POINT | ||
| ``` |
There was a problem hiding this comment.
Add fenced code block languages to satisfy Markdown linting.
These fenced blocks are missing a language identifier (MD040), so docs lint can fail. Add an explicit language (likely bash; text where appropriate).
Suggested pattern
-```
+```bash
./httpdirfs --help
</details>
Also applies to: 55-57, 61-63, 80-83, 88-92, 96-98, 102-104, 108-110, 120-123, 128-133, 156-158, 178-180, 230-232, 275-279
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>
[warning] 44-44: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @README.md around lines 44 - 46, The README's fenced code blocks are missing
language identifiers (causing MD040); update each triple-backtick block examples
(e.g., lines showing commands like "./httpdirfs -f --cache $URL $MOUNT_POINT"
and other CLI examples) to include an explicit language tag such as bash (or
text where appropriate). Search for all code blocks referenced in the comment
(sections around the shown ranges) and prepend the opening withbash (or
| For \*sonic servers, rather than using the Gumbo parser, this program parse | ||
| \*sonic servers' XML responses using |
There was a problem hiding this comment.
Fix grammar in technical details sentence.
Line 299 currently says “this program parse”; this should be “this program parses”.
Proposed fix
-For \*sonic servers, rather than using the Gumbo parser, this program parse
+For \*sonic servers, rather than using the Gumbo parser, this program parses📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| For \*sonic servers, rather than using the Gumbo parser, this program parse | |
| \*sonic servers' XML responses using | |
| For \*sonic servers, rather than using the Gumbo parser, this program parses | |
| \*sonic servers' XML responses using |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 299 - 300, Fix the grammar in the README sentence
that currently reads "this program parse" by changing it to "this program
parses" so the verb agrees with the singular subject; locate the sentence
containing "this program parse" (the technical details paragraph referencing
Gumbo parser and sonic servers' XML responses) and update the phrase to "this
program parses".
1 participant
This PR introduces several CI improvements and modernizations:
master.yamlfmtfor all YAML files.mdformat(equipped withmdformat-gfmandmdformat-gfm-alerts) to natively support GitHub Alerts syntax at an 80-character wrap width.prettier-ignorecomments..pre-commit-config.yamlto clean multi-line literal blocks.PKG_CONFIG_PATHdefinition inbuild.ymlincrementally.Summary by CodeRabbit
Documentation
Chores