Append actor note to AD info field on user disable/enable#479
Open
claire-peters wants to merge 2 commits into
Open
Append actor note to AD info field on user disable/enable#479claire-peters wants to merge 2 commits into
claire-peters wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_append_info_note()toLDAPConninldap/utils.py— reads the current ADinfofield, appends\nYYYY-MM-DD <role> <username> disabled/enabled via CF, and writes back; skips and logs a warning if the result would exceed 1024 charactersdeactivate_user()andreactivate_user()onLDAPConnto accept optionalactor_username/actor_roleand call_append_info_noteafter a successful operationremove_member_from_group()onLDAPConnto forward actor params todeactivate_userproject_preremove_projectuserandproject_reactivate_projectusersignal sends inproject/views.pyand their receivers inldap/signals.py_actor_role_label()helper inproject/views.pyto map full role names to short labels (PI, GM, AM, SM) for the noteTest plan
infofield gains a line like2026-06-17 PI mmcfee disabled via CFinfogains2026-06-17 GM msyed enabled via CFinfofield to near 1024 chars and confirm disable is still applied but the note write is skipped with a warning log entryinfois unchanged (no note appended for plain group removal)infocontent is preserved (append, not replace)