test: cover encoded UTF-8 URI resolution - #200
Open
Poliklot wants to merge 1 commit into
Open
Conversation
Add coverage for the encoded Cyrillic reference from fastify#157 and the corresponding JSON Schema URI fixture from sagold/json-schema-library#82. Co-authored-by: Dmitry Arkhipov <2089893+ekzobrain@users.noreply.github.com> Signed-off-by: Poliklot <poliklot@vk.com>
Poliklot
marked this pull request as ready for review
August 6, 2026 15:53
mcollina
requested changes
Aug 11, 2026
mcollina
left a comment
Member
There was a problem hiding this comment.
I'm sorry but I don't understand this, how can we close that issue with just a test?
Author
|
@mcollina You’re absolutely right: this PR only adds regression coverage; it does not implement the functional fix. I verified that the reported reproducer returns So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve()retains UTF-8 percent-encoded path segments instead of producing legacyunescape()-style Latin-1 output;uri-jshad been used as a workaround;The commit credits the original report and fixture research:
Co-authored-by: Dmitry Arkhipov <2089893+ekzobrain@users.noreply.github.com>Closes #157.
Validation
npm testnpm run lintnpm run test:typescriptnpm run test:browser:chromium