You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
piscina@5.0.0 removed runTask() in favor of run() (deprecated since v4). Since index.js still called pool.runTask(...) in render, turboSend and generate, every request threw TypeError: pool.runTask is not a function, which surfaced as 500s on all routes and made all 11 unit tests fail.
Hmm, there's an update for the svelte dependency, but it's best to do it separately. There are some changes to be made, and I think it's all in pure ESM since version 4.
I preferred not to risk it and only updated the piscina dependency. 😅
Not really a problem, it is used in devDependencies. So, unlike cookie only the test works is enough.
I’ve also updated the fastify-plugin package, so we can close this PR as well: #214; as for the svelte dependency, it’s better to handle that in a separate PR, I need to see what changes are required in the example 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
Changes:
piscina@5.0.0removedrunTask()in favor ofrun()(deprecated since v4). Sinceindex.jsstill calledpool.runTask(...)inrender,turboSendandgenerate, every request threwTypeError: pool.runTask is not a function, which surfaced as 500s on all routes and made all 11 unit tests fail.Note: