Skip to content

chore: upgrade piscina to v5.x#220

Merged
climba03003 merged 2 commits into
mainfrom
chore/upgrade-piscina-v5
Jul 11, 2026
Merged

chore: upgrade piscina to v5.x#220
climba03003 merged 2 commits into
mainfrom
chore/upgrade-piscina-v5

Conversation

@Tony133

@Tony133 Tony133 commented Jul 11, 2026

Copy link
Copy Markdown
Member

Proposal:

Changes:

  • piscina@5.0.0 removed runTask() in favor of run() (deprecated since v4). Since index.js still called pool.runTask(...) in render, turboSend and generate, every request threw TypeError: pool.runTask is not a function, which surfaced as 500s on all routes and made all 11 unit tests fail.

Note:

@Tony133 Tony133 marked this pull request as ready for review July 11, 2026 13:55
@Tony133 Tony133 requested a review from a team July 11, 2026 13:56

@climba03003 climba03003 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upgrade all the dependencies in once?

@Tony133

Tony133 commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

Can you upgrade all the dependencies in once?

Hmm, there's an update for the svelte dependency, but it's best to do it separately. There are some changes to be made, and I think it's all in pure ESM since version 4.
I preferred not to risk it and only updated the piscina dependency. 😅

@climba03003

Copy link
Copy Markdown
Member

There are some changes to be made, and I think it's all in pure ESM since version 4.

Not really a problem, it is used in devDependencies. So, unlike cookie only the test works is enough.

@Tony133

Tony133 commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

Not really a problem, it is used in devDependencies. So, unlike cookie only the test works is enough.

I’ve also updated the fastify-plugin package, so we can close this PR as well: #214; as for the svelte dependency, it’s better to handle that in a separate PR, I need to see what changes are required in the example 😉

@climba03003 climba03003 merged commit 7da2949 into main Jul 11, 2026
17 checks passed
@climba03003 climba03003 deleted the chore/upgrade-piscina-v5 branch July 11, 2026 15:58
@Tony133 Tony133 restored the chore/upgrade-piscina-v5 branch July 12, 2026 09:17
@Tony133 Tony133 deleted the chore/upgrade-piscina-v5 branch July 12, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants