add c++ wrapper for prometheus & common metrics - #48430
Merged
Merged
Conversation
clintjedwards
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
StatsManagerwill construct an internally-ownedPrometheusServerwhen prometheus metrics are enabled. This works as long as there is only oneStatsManagerinstance in the whole process. However, the proxy component can be configured to have multiple workers, in which case multipleStatsManagerinstances will be created, one per worker. These configuration options are in conflict. It is not possible to enable multiple workers and prometheus metrics at the same time, since only one worker would be able to bind the configured port.To make prometheus metrics work when there are multiple
StatsManagerinstances, we need to rethink this. Either each instance needs to bind its own port, or multiple instances need to be able to share the same port. I think the latter approach is tidier, as it allows the worker count to be tuned without impacting scraper configurations.Toward that end, this PR adds C++ wrappers around the prometheus and common metrics FFIs, to make it easy to construct these things outside of
StatsManager. They are not used anywhere yet, but the plan is for applications to create onePrometheusServerand oneCommonMetricsinstance, and then share theCommonMetricsinstance with one or moreStatsManagerinstances.