[release] Fix get_version_int to support new build var - #48437
Merged
Merged
Conversation
In #48436 we updated `build.rs` to support overriding the final version string. This did not account for `get_version_int` which assumes the build string is the older version and strips it to find the semver string. Since the only place we use this function is to parse out the major semver version for feature flagging, this PR fixes things by always pulling from the `cargo.toml` listed version instead.
jkarneges
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #48436 we updated
build.rsto support overriding the final version string. This did not account forget_version_intwhich assumes the build string is the older version format and strips it to find the semver string.Since the only place we use this function is to parse out the major semver version for feature flagging, this PR fixes things by always pulling from the
cargo.tomllisted version instead.