Bundled fixes: transaction history infinite scroll + mnemonic backup verify quiz (#705, #698) - #5
Open
favvy994 wants to merge 2 commits into
Open
Bundled fixes: transaction history infinite scroll + mnemonic backup verify quiz (#705, #698)#5favvy994 wants to merge 2 commits into
favvy994 wants to merge 2 commits into
Conversation
Guard against duplicate transaction rows when cursor pages overlap, e.g. when a new transaction arrives midway through a scroll session. Refs Fracverse#705
Add a verification step after the phrase is displayed that asks the user to select the exact word for positions 3, 7, and 11 from scrambled options. The wallet only unlocks once all selections match the generated recovery phrase. Refs Fracverse#698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Stellar Wave mobile app issues bundled into this single PR.
Fracverse#705 — Infinite scroll pagination robustness (transaction history)
onEndReached→ cursor-basedloadMore. This PR hardens it by deduplicating overlapping cursor pages inuseTransactions, so rows aren't duplicated when a new transaction arrives mid-scroll and the backend returns already-seen items.Fracverse#698 — Mnemonic backup verify quiz step (wallet generation)
Validation
node_modules) is not installed in this workspace, so fullnpm run lint/tsccould not be executed; changes are minimal TypeScript and visually verified.Closes Fracverse#705
Closes Fracverse#698