build(cmake): prefer system dependencies over FetchContent#197
Merged
Conversation
AuroraRAS
commented
Jul 9, 2026
AuroraRAS
commented
- Modify CMake scripts (CURL, miniaudio, OpenAL, SDL3) to check for system packages before falling back to FetchContent
- Update Linux documentation to include SDL3_image-devel
- Adjust deployment scripts to handle optional SDL3 library paths and support diverse FFmpeg paths across Linux distributions
- Modify CMake scripts (CURL, miniaudio, OpenAL, SDL3) to check for system packages before falling back to FetchContent - Update Linux documentation to include SDL3_image-devel - Adjust deployment scripts to handle optional SDL3 library paths and support diverse FFmpeg paths across Linux distributions
Owner
|
Thanks for the PR. Originally I was working on Ubuntu 24.04 which does not have the SDL3 package, so the solution was downloading it at compilation time. Since the latest LTS does have the packages, your approach makes more sense. |
Owner
|
@AuroraRAS can you please fix the build pipeline? thanks! |
Add operating system detection to the CMake files to prevent `find_package` from affecting other operating systems.
I have updated both flatpak/com.fbraz3.GeneralsXZH.yml and flatpak/com.fbraz3.GeneralsX.yml. I changed the hardcoded cp commands for sdl3, sdl3_image, and openal_soft to be conditional.
Author
My environment lacks Flatpak, so I couldn't complete the testing locally, but I suspect I've fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.