Skip to content

Add @drfed/web packages (SolidStart Frontend)#21

Merged
dodok8 merged 25 commits into
fedify-dev:mainfrom
dodok8:main
Jul 8, 2026
Merged

Add @drfed/web packages (SolidStart Frontend)#21
dodok8 merged 25 commits into
fedify-dev:mainfrom
dodok8:main

Conversation

@dodok8

@dodok8 dodok8 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Close #20

  • Add @drfed/web packages.
  • Extends oxlint for Solid.
  • Add mise run dev:web command.
  • Update Contributing.md and README.md

@dahlia dahlia changed the title Add @drfed/web packages(SolidStart Frontend) Add @drfed/web packages (SolidStart Frontend) Jul 3, 2026
@dodok8

dodok8 commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

I will make another dev command and make dev command to AIO command.

@dodok8 dodok8 marked this pull request as ready for review July 3, 2026 09:10
@dodok8 dodok8 requested review from 2chanhaeng, dahlia and sij411 July 4, 2026 13:29

@dahlia dahlia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those favicons seem incorrectly rasterized. The dino must have outlines:

@dodok8 dodok8 requested a review from dahlia July 6, 2026 06:30

@dahlia dahlia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon looks pixelated. It seems like the resolution was set incorrectly when rasterizing the SVG image.

@dodok8 dodok8 requested a review from dahlia July 6, 2026 16:00

@dahlia dahlia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several nitpicks.

Comment thread packages/web/src/components/Counter.css Outdated
Comment thread packages/web/src/components/Counter.css Outdated
Comment thread packages/web/src/components/Counter.tsx
Comment thread packages/web/public/manifest.webmanifest Outdated
Comment thread packages/web/package.json Outdated
Comment thread packages/web/README.md Outdated
Comment thread packages/web/README.md Outdated
Comment thread packages/web/README.md Outdated
Comment thread .gitignore Outdated

@2chanhaeng 2chanhaeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code files are missing GPL comments. Is this intentional?

On the other hand, some code looks like auto-generated files from the init command-for example, packages/web/src/routes/index.tsx is exactly the same as the solidstart template file except for GPL comments and an empty line 18-but they include GPL comments. I'm not sure if this is okay.

@dodok8

dodok8 commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Some code files are missing GPL comments. Is this intentional?

On the other hand, some code looks like auto-generated files from the init command-for example, packages/web/src/routes/index.tsx is exactly the same as the solidstart template file except for GPL comments and an empty line 18-but they include GPL comments. I'm not sure if this is okay.

It is code skeleton that will gonna be edit, so I think is should include licences.

@dodok8 dodok8 merged commit ebc4d25 into fedify-dev:main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initialize SolidStart (@drfed/web package)

3 participants