Add @drfed/web packages (SolidStart Frontend)#21
Conversation
@drfed/web packages(SolidStart Frontend)@drfed/web packages (SolidStart Frontend)
|
I will make another dev command and make dev command to AIO command. |
dahlia
left a comment
There was a problem hiding this comment.
The favicon looks pixelated. It seems like the resolution was set incorrectly when rasterizing the SVG image.
2chanhaeng
left a comment
There was a problem hiding this comment.
Some code files are missing GPL comments. Is this intentional?
On the other hand, some code looks like auto-generated files from the init command-for example, packages/web/src/routes/index.tsx is exactly the same as the solidstart template file except for GPL comments and an empty line 18-but they include GPL comments. I'm not sure if this is okay.
It is code skeleton that will gonna be edit, so I think is should include licences. |
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
Close #20
@drfed/webpackages.mise run dev:webcommand.Contributing.mdandREADME.md