Skip to content

Check for only Major version updates in JS deps - #136

Open
bhoy-troy wants to merge 1 commit into
fedora-eln:masterfrom
bhoy-troy:feature/dependency-lts-#134
Open

bhoy-troy wants to merge 1 commit into
fedora-eln:masterfrom
bhoy-troy:feature/dependency-lts-#134

Conversation

@bhoy-troy

Copy link
Copy Markdown
Collaborator

The previous check_cdn_updates.py created GitHub issues for any newer npm version — including patch/minor updates and major upgrades. This caused noise and offered no way to distinguish if an upgrade was necessary.

Solution

Replace the flat version comparison with a dynamic stack resolver that finds the maximum mutually-compatible version for every CDN package by scanning npm metadata (peerDependencies, dependencies, ranged devDependencies) across all packages deployed in templates/layout.html.

Changes

  • Replaced top-level functions with three classes: StackResolver, LayoutParser, LtsPolicy
  • StackResolver: owns all npm I/O and semver logic
  • LayoutParser: parses <script src> / from HTML to extract deployed versions and CDN URLs
  • LtsPolicy: classifies results, prints output, writes cdn-update-report.md
  • Optimised npm I/O: one HTTP request per package
  • Fixed missing @classmethod decorator on check_semver_constraint
  • Added --verbose flag: writes cdn-update-report.md

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ad8b527d-db45-4b69-af46-a9157c1051ab


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants