Some UX enhancements to maps plugin#38
Open
Bortseb wants to merge 5 commits into
Open
Conversation
Lets you use Ctrl + Scroll wheel to zoom in/out of map based on location of pointer. Also adds a text overlay when scrolling over the map, and not holding Ctrl, to let you know this feature exists. Adds a Zoom to bounds control to the top left of the map. Fixes build command in package.json to also be compatible with Windows machines.
Update the scroll modified key to be more cross-platform compatible, and suggest ⌘+scroll for apple devices.
Member
|
This was disabled back in 2018. See #23 |
Author
|
Ah I see! But i didn't re-enable it in general, I only enabled it if you hold down ctrl (like you might have seen others do with embedded maps).. so the page still scrolls as usual if are using the scroll wheel over a map, but it does temporarily show a text overlay as a hint to teach you that you can still zoom the map if you hold Ctrl, or command on Mac. |
Author
|
It's still disabled in the default case |
Don't try and determine the user's device type, just display a more universal overlay.
Author
|
Example of how a map looks when scrolling normally over it, as page scrolls 
|
* Hide the overlay if the user starts interacting with the map * Prevent a strange outline appearing around the map if the user holds down a modifier key like shift or ctrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets you use Ctrl + Scroll wheel to zoom in/out of map based on location of pointer. Also adds a text overlay when scrolling over the map, and not holding Ctrl, to let you know this feature exists.
Adds a Zoom to bounds control to the top left of the map.
Fixes build command in package.json to also be compatible with Windows machines.