Skip to content

Find the Missing Number (issue #99) - #111

Open
Yasas4D wants to merge 2 commits into
fengyuanyang:mainfrom
Yasas4D:find-missing-number
Open

Find the Missing Number (issue #99)#111
Yasas4D wants to merge 2 commits into
fengyuanyang:mainfrom
Yasas4D:find-missing-number

Conversation

@Yasas4D

@Yasas4D Yasas4D commented Oct 24, 2020

Copy link
Copy Markdown

I implemented the function and added two test cases.
Please take the PR and make it acceptable for hacktoberfest competition
Thank you

@Yasas4D

Yasas4D commented Oct 24, 2020

Copy link
Copy Markdown
Author

Why are these checks failing? It's not a my problem right?

@fengyuanyang fengyuanyang left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi can you have a look on it

Comment on lines +12 to +15
int a[] = {1, 2, 4, 5, 6};
int missedNumber = MissingNumber.getMissingNo(a);
// assert
assertEquals(7, missedNumber);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you didn't pass this test
the missed Number here should be. 3 , not 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants