Skip to content

Data sketches 0.4 fixup #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fimad merged 4 commits into from
May 20, 2026
Merged

Data sketches 0.4 fixup #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d731bff
Fix build with data-sketches 0.4
rickynils Apr 4, 2026
3fb40ee
Make tests pass with data-sketches 0.4
fimad May 20, 2026
ea77ff4
Update CI stack.yaml
fimad May 20, 2026
23e80e6
Update stack-lts-22.yaml
fimad May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/stack-lts-16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ packages:
- ../prometheus-proc
- ../wai-middleware-prometheus
extra-deps:
- data-sketches-0.3.1.0
- data-sketches-core-0.1.0.0
- data-sketches-0.4.0.0
- data-sketches-core-0.2.0.1
- unix-memory-0.1.2
resolver: lts-16.6
2 changes: 2 additions & 0 deletions .ci/stack-lts-21.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ packages:
- ../prometheus-proc
- ../wai-middleware-prometheus
extra-deps:
- data-sketches-0.4.0.0
- data-sketches-core-0.2.0.1
- unix-memory-0.1.2
resolver: lts-21.25
2 changes: 2 additions & 0 deletions .ci/stack-lts-22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ packages:
- ../wai-middleware-prometheus
extra-deps:
- unix-memory-0.1.2
- data-sketches-0.4.0.0
- data-sketches-core-0.2.0.1
resolver: lts-22.12
4 changes: 3 additions & 1 deletion .ci/stack-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ packages:
- ../wai-middleware-prometheus
extra-deps:
- unix-memory-0.1.2
resolver: nightly-2024-03-01
- data-sketches-0.4.0.0
- data-sketches-core-0.2.0.1
resolver: nightly-2026-04-01
4 changes: 2 additions & 2 deletions prometheus-client/prometheus-client.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ library
, utf8-string
, exceptions
, text
, data-sketches < 0.4
, data-sketches >= 0.4 && <0.5
ghc-options: -Wall

test-suite doctest
Expand Down Expand Up @@ -86,7 +86,7 @@ test-suite spec
, exceptions
, text
, primitive
, data-sketches < 0.4
, data-sketches >= 0.4 && <0.5
ghc-options: -Wall

benchmark bench
Expand Down
3 changes: 2 additions & 1 deletion prometheus-client/src/Prometheus/Metric/Summary.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ determineK (rank_, acceptableError) = go 6
summary :: Info -> [Quantile] -> Metric Summary
summary info quantiles_ = Metric $ do
rs <- mkReqSketch kInt HighRanksAreAccurate
mv <- newMVar $ rs {criterion = (:<=)}
setCriterionLE rs
mv <- newMVar rs
let summary_ = MkSummary mv quantiles_
return (summary_, collectSummary info summary_)
where
Expand Down
5 changes: 3 additions & 2 deletions stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ packages:
- wai-middleware-prometheus
extra-deps:
- unix-memory-0.1.2
- data-sketches-0.3.0.0
resolver: lts-18.5
- data-sketches-0.4.0.0
- data-sketches-core-0.2.0.1
resolver: lts-24.40
Loading