strip inherited npm_* env vars before nested npx calls#88
Merged
developersdigest merged 1 commit intomainfrom Apr 10, 2026
Merged
strip inherited npm_* env vars before nested npx calls#88developersdigest merged 1 commit intomainfrom
developersdigest merged 1 commit intomainfrom
Conversation
when this cli is launched via 'npx -y firecrawl-cli@VERSION', npm injects
npm_command/npm_lifecycle_event/npm_execpath/INIT_CWD into the process
env. those vars leak into nested execSync('npx -y skills add ...') calls
and cause the loop's second iteration to silently exit after the first
install completes — published 1.14.0 only installs from firecrawl/cli
even though SKILL_REPOS contains both repos.
cleanNpmEnv() in skills-install.ts strips those vars; init.ts and
setup.ts pass it as the env to every nested execSync. added a
regression test that primes process.env with the leaking vars and
asserts every install call sees a clean env. bumped to 1.14.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when this cli is launched via 'npx -y firecrawl-cli@VERSION', npm injects npm_command/npm_lifecycle_event/npm_execpath/INIT_CWD into the process env. those vars leak into nested execSync('npx -y skills add ...') calls and cause the loop's second iteration to silently exit after the first install completes — published 1.14.0 only installs from firecrawl/cli even though SKILL_REPOS contains both repos.
cleanNpmEnv() in skills-install.ts strips those vars; init.ts and setup.ts pass it as the env to every nested execSync. added a regression test that primes process.env with the leaking vars and asserts every install call sees a clean env. bumped to 1.14.1.