[pull] master from prestodb:master - #984
Merged
Merged
Conversation
## Description The Iceberg SQL support table used the RST simple-table format, where the `===` rules and every row's padding are pinned to the widest cell. Converted it to `list-table`. The rendered page is unchanged. ## Motivation and Context Adding one operation to that table means re-padding all 20 rows, so the real change disappears into the diff. It has already drifted: `ALTER TABLE ALTER COLUMN SET DEFAULT` fills the first column to its very last character, and the four rows around it sit four spaces off. The next operation someone documents would have to widen the rules again. `list-table` also lets the Comments column wrap across lines, which the simple format doesn't allow. The rest of this file already uses `list-table` in three places, so this just brings the table in line with its neighbours. ## Impact Docs only. No rendered change, no user-facing behaviour change. ## Test Plan Parsed the table before and after with docutils and compared the resulting doctrees: - both produce 21 rows and 4 columns, with no warnings - cell text compares identical across every row ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes ``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Convert the Iceberg SQL support table to list-table format without changing its rendered documentation. Enhancements: - Convert the Iceberg SQL support table to reStructuredText list-table format while preserving its rendered content and structure. Documentation: - Improve the maintainability and readability of the Iceberg SQL support table documentation.
…ame name (#28462) ## Description This fixes the case where an Arrow record batch has duplicate column names. The fix first checks if the connector output column layout matches the columns in the Arrow record batch. If they match then the Arrow vectors are retrieved by position, which allows for duplicate column names. If they do not match, then the connector will lookup each ouput column by name in the record batch. This requires the output columns to be a subset of the record batch columns, with no duplicate names. It can not support the case where there are both less output columns and duplicate names. ## Motivation and Context The Arrow connector has been used with TVFs where the output columns are a subset of the columns in the Arrow record batches. The connector then locates the column data by looking the Arrow vector by name. This lookup fails when the record batch contains duplicate column names and returns an error: ``` Exception: VeloxRuntimeError column with name 'duplicate_col' not found ``` ## Impact NA ## Test Plan Added native unit tests for cases where there is a duplicate column name, and additional columns in the batch that are not output columns. ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == Prestissimo (Native Execution) Changes * Fix Arrow connector column projection when there are duplicate column names. ``` ## Summary by Sourcery Fix Arrow Flight projection for duplicate column names and pruned output columns. Bug Fixes: - Fix Arrow Flight column projection for record batches containing duplicate column names. Enhancements: - Support selecting Arrow output columns by position when the batch schema matches the requested layout, while retaining name-based projection for pruned columns. - Use consistent Arrow result error handling when opening streams, reading schemas, and fetching record batches. Tests: - Add native connector coverage for duplicate column names and pruned record-batch columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )