[pull] master from prestodb:master - #985
Merged
Merged
Conversation
…28477) ## Description <!---Describe your changes in detail--> minio/minio image has been removed from dockerhub, so use quay.io image for now. https://github.com/prestodb/presto/actions/workflows/tests.yml https://github.com/prestodb/presto/actions/runs/34638763193/job/103436811992 https://github.com/prestodb/presto/actions/runs/34854738843/job/104011281351 ``` [ERROR] com.facebook.presto.hive.TestHiveQueriesWithCatalogName.init Time elapsed: 2.841 s <<< FAILURE! org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=minio/minio:RELEASE.2025-09-07T16-13-09Z, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@2eb7ad9e) at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1308) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317) at com.facebook.presto.testing.containers.TestContainers.startOrReuse(TestContainers.java:41) at com.facebook.presto.testing.containers.BaseTestContainer.lambda$startContainer$2(BaseTestContainer.java:113) at net.jodah.failsafe.Functions.lambda$get$0(Functions.java:48) at net.jodah.failsafe.RetryPolicyExecutor.lambda$supply$0(RetryPolicyExecutor.java:66) at net.jodah.failsafe.Execution.executeSync(Execution.java:128) at net.jodah.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:379) at net.jodah.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:68) at com.facebook.presto.testing.containers.BaseTestContainer.startContainer(BaseTestContainer.java:113) at com.facebook.presto.testing.containers.MinIOContainer.startContainer(MinIOContainer.java:78) at com.facebook.presto.testing.containers.BaseTestContainer.start(BaseTestContainer.java:124) at com.facebook.presto.hive.containers.HiveMinIODataLake.start(HiveMinIODataLake.java:127) at com.facebook.presto.hive.TestHiveQueriesWithCatalogName.createQueryRunner(TestHiveQueriesWithCatalogName.java:52) at com.facebook.presto.tests.AbstractTestQueryFramework.init(AbstractTestQueryFramework.java:95) at jdk.internal.reflect.GeneratedMethodAccessor2030.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135) at org.testng.internal.invokers.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:65) at org.testng.internal.invokers.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:381) at org.testng.internal.invokers.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:319) at org.testng.internal.invokers.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:178) at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:122) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840) Caused by: com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"pull access denied for minio/minio, repository does not exist or may require 'docker login': denied: requested access to the resource is denied"} at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:241) at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269) ... 1 more ``` ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> Fix pipeline issue where we are unable to pull minio image. ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> None ## Test Plan <!---Please fill in how you tested your change--> Run presto-hive tests in the pipeline. ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Bug Fixes: - Update the default MinIO test image source to Quay.io so CI can pull it reliably without Docker Hub access limitations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )