4.x review follow-ups: isProbablyReaderable unit tests, docs for the content wrapper and rewrite#43
Merged
fivefilters merged 2 commits intoJul 14, 2026
Conversation
Mirror Mozilla's test/test-isProbablyReaderable.js: option tests for minContentLength, minScore, and a custom visibilityChecker (the corpus-wide readerable check already runs in ReadabilityTest). Widen minScore to float, as in Readability.js, whose own tests use fractional scores. Document the tuning parameters and the check-before-parse example in the README, note in UPGRADE.md how to reproduce 3.x's unwrapped content output, and credit the tooling used for the 4.0 rewrite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XtjkDhXFTnEiyM8uzh8ZmA
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XtjkDhXFTnEiyM8uzh8ZmA
fivefilters
marked this pull request as ready for review
July 14, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from a 3.x → 4.x compatibility review of the rewrite branch (stacked on #41):
test/ReaderableTest.php(new) — unit tests forReaderable::isProbablyReaderable, mirroring Mozilla'stest/test-isProbablyReaderable.js: the four document sizes under default options, lower/higherminContentLength, lower/higherminScore, and customvisibilityCheckerbehavior (both directions), plus a PHP-specific case for HTML-string input. The corpus-wide check against each test page'sreaderablemetadata key already runs inReadabilityTest::testReaderable(the equivalent of upstream's corpus loop) and is unchanged.src/Readerable.php—$minScorewidenedint→float. Readability.js accepts fractional scores and its own test suite usesminScore: 11.5; the internal score is already a float (sqrt).README.md— theisProbablyReaderablesection now documents the three tuning parameters (minContentLength,minScore,visibilityChecker) with their Readability.js defaults and uses upstream's check-before-parse example; the intro paragraph now credits the tooling used for the 4.0 rewrite and mentions the PHP 8.4 native HTML parser and PHP 8.5 URL parser it builds on.UPGRADE.md— the note about the new<div id="readability-page-1" class="page">wrapper (3.x emitted no wrapper) now includes a one-liner to reproduce the unwrapped 3.x output:$article->contentElement->firstElementChild->innerHTML.No option was added to disable the content wrapper: Readability.js always emits it and offers no toggle, and keeping the output byte-identical to upstream is a goal of 4.x — the one-liner above covers callers who want the old shape.
Testing
./vendor/bin/phpunit— 480 tests, 1058 assertions, all green (8 new tests)../vendor/bin/psalm— no errors.wordpresspage) reproduces the 3.x-style output.🤖 Generated with Claude Code
https://claude.ai/code/session_01XtjkDhXFTnEiyM8uzh8ZmA
Generated by Claude Code