Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Ground-up port from the latest Readability.js (v0.6.0) using Claude's Fable mode
- HTML5-PHP dependency; `ext-xml` requirement
- Options that existed as libxml workarounds: `parser`, `substituteEntities`, `normalizeEntities`, `summonCthulhu`
- The custom DOM subclass layer (`src/Nodes/`) and its workarounds (attribute-based state, shifting-aware iteration)
- The Docker-based local test setup (`docker-compose.yml`, `Makefile`, `docker/`); tests and static analysis run directly on PHP 8.4/8.5, locally and in CI

## [v3.3.3](https://github.com/fivefilters/readability.php/releases/tag/v3.3.3)
- Fix type error - extends type support to add DOMProcessingInstruction in more method signatures (reported by @reinierkors)
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ Things that intentionally differ from the JS (don't "fix" these): scoring state
``` bash
$ ./vendor/bin/phpunit # requires PHP 8.4+
$ ./vendor/bin/psalm # static analysis; CI runs this too
$ make test-all # multiple PHP versions; requires docker and docker-compose
```

CI runs both on PHP 8.4 and 8.5.


**Happy coding**!
15 changes: 0 additions & 15 deletions Makefile

This file was deleted.

6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,7 @@ composer install --prefer-source
./vendor/bin/phpunit
```

To test against multiple PHP versions with Docker:

```bash
make test-all # or make test-8.4 / make test-8.5
```
CI runs the suite (plus [Psalm](https://psalm.dev/) static analysis) on PHP 8.4 and 8.5.

### Updating the expected test output

Expand Down
16 changes: 0 additions & 16 deletions docker-compose.yml

This file was deleted.

6 changes: 0 additions & 6 deletions docker/php/Dockerfile

This file was deleted.