feat: doorbell#36
Open
yhdengh wants to merge 1 commit into
Open
Conversation
yhdengh
force-pushed
the
arca-networking-pr-2
branch
from
143e399 to
cac780f
Compare
yhdengh
force-pushed
the
arca-networking-pr-1
branch
from
9cadb75 to
220309c
Compare
yhdengh
force-pushed
the
arca-networking-pr-2
branch
from
cac780f to
d61f1ac
Compare
Contributor
Author
|
@ruiting-chen Could you take a look at this PR first? It would probably be easier for the rebasing if we first merge doorbell and the sync stream into the bidirectional pipe PR. |
GregoryLi360
force-pushed
the
arca-networking-pr-1
branch
from
220309c to
ced5641
Compare
ruiting-chen
force-pushed
the
arca-networking-pr-2
branch
from
d61f1ac to
73700a1
Compare
|
Combined Greg's update for owned shm region design in pr#34 with DoorBell generic, producing BidirectionalPipe<R, D> and SyncStream<R, D> |
yhdengh
force-pushed
the
arca-networking-pr-2
branch
2 times, most recently
from
ed08579 to
5a5a663
Compare
yhdengh
force-pushed
the
arca-networking-pr
branch
from
854e908 to
4e69589
Compare
yhdengh
force-pushed
the
arca-networking-pr-2
branch
from
5a5a663 to
c55cb8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequenced after #35
This PR adds
DoorBell/DoorBellWaitertraits for allowing one end of the bidirectional pipe to notify the other end on new readable content and new writable space in the pipe.In the VM ==> Host direction,
DoorBell::ringis a write to an MMIO address, andDoorBellWaiteris a wrapper around aKVM_IOEVENTFD.In the Host ==> VM direction,
DoorBell::ringis a write to aKVM_IRQFD. There is noDoorBellWaiteras the interrupts will be handled by kthread logic.This PR does not include tests on the mechanisms. It makes more sense to have integration tests after the control pipe protocol is implemented.