Tiankuan-lanzhichuan - #113
Open
JerryJonny wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an NPU backend implementation for
multi_tensor_adamin TransformerEngine-FL.This implementation adapts the TE-FL
multi_tensor_adaminterface to the NPU Adam/AdamW execution path, including input validation, optimizer state handling, dtype handling, noop behavior, and backend registration.With this change,
multi_tensor_adamcan dispatch to the NPU vendor backend instead of falling back to thereference.torchimplementation.Type of change
Changes
multi_tensor_adam.multi_tensor_adamfor the NPU vendor backend.reference.torchimplementation as the reference/fallback path.Validation
The implementation was validated with dedicated local optimizer tests and end-to-end Qwen3.5 MoE training on 16 Ascend NPUs.
Training configuration:
Correctness and stability:
reference.torchimplementation.Performance was measured over iterations 11-100 to exclude warm-up:
reference.torchvendor.npuThe NPU backend reduced end-to-end iteration latency by approximately 11.1%, corresponding to about 1.125x speedup in this configuration.
Checklist