Skip to content

Emit order completed event after status update #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PremSharma-Intelegencia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Emit order completed event after status update #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions server/src/Models/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,24 +1379,25 @@ public function notifyCompleted()
*
* The process involves the following steps:
* 1. Creating a new Activity instance with the 'completed' code and relevant details.
* 2. Notifying that the order has been completed via `notifyCompleted`.
* 3. Updating the order's activity with the new 'completed' activity through `updateActivity`.
* 2. Updating the order's activity with the new 'completed' activity through `updateActivity`,
* which applies and persists the 'completed' status.
* 3. Notifying that the order has been completed via `notifyCompleted`.
*
* @param Proof|null $proof Optional. Additional proof or details for the activity update.
*
* @return Order the order instance with updated activities, reflecting the completion status
*/
public function complete(?Proof $proof = null): self
{
$this->notifyCompleted();

$doesntHaveCompletedActivity = TrackingStatus::where(['tracking_number_uuid' => $this->tracking_number_uuid, 'code' => 'COMPLETED'])->doesntExist();
if ($doesntHaveCompletedActivity) {
$activity = $this->config()->getCompletedActivity();

return $this->updateActivity($activity, $proof);
$this->updateActivity($activity, $proof);
}

$this->notifyCompleted();

return $this;
}

Expand Down