Skip to content

Get machine specification only when required to compile graph #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliottslaughter wants to merge 1 commit into from
Closed

Get machine specification only when required to compile graph #1684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bin/compile-model/src/compile-model/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,16 +239,15 @@ int main(int argc, char **argv) {
return from_v1(cg_json.get<V1ComputationGraph>());
}();

MachineSpecification machine_specification =
get_machine_specification(machine_specification_json_path);

MappedParallelComputationGraph mpcg = [&]() {
if (strategy == "passthrough") {
return lift_cg_to_mpcg_for_single_device(cg);
} else {
// Need to root this on the stack so it stays alive for the whole session
std::optional<ManagedPerDeviceFFHandle> managed_handle =
create_device_handle(cpu);
MachineSpecification machine_specification =
get_machine_specification(machine_specification_json_path);
CostEstimator estimator =
create_cost_estimator(machine_specification, cpu, managed_handle);
AlgorithmConfig algorithm =
Expand Down
Loading