chore: enable libav and vvdec plugins for source-compiled GStreamer in Dockerfile#364
Open
mdimopoulos wants to merge 1 commit into
Open
chore: enable libav and vvdec plugins for source-compiled GStreamer in Dockerfile#364mdimopoulos wants to merge 1 commit into
mdimopoulos wants to merge 1 commit into
Conversation
mdimopoulos
changed the title
rsanchez87
reviewed
Jun 16, 2026
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \ | ||
| \ | ||
| # 5. Extract pre-compiled cargo-c binaries directly to skip compilation errors \ | ||
| curl -L "https://github.com/lu-zero/cargo-c/releases/latest/download/cargo-c-x86_64-unknown-linux-musl.tar.gz" | tar -xz -C ${CARGO_HOME}/bin && \ |
Contributor
There was a problem hiding this comment.
Can we use something like ${ARCH}, instead hardcoded value x86_64?
rsanchez87
reviewed
Jun 16, 2026
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \ | ||
| \ | ||
| # 5. Extract pre-compiled cargo-c binaries directly to skip compilation errors \ | ||
| curl -L "https://github.com/lu-zero/cargo-c/releases/latest/download/cargo-c-x86_64-unknown-linux-musl.tar.gz" | tar -xz -C ${CARGO_HOME}/bin && \ |
Contributor
There was a problem hiding this comment.
same here, can we use ${CARGO_C_VERSION}, instead latest? A new release can breaks the building
rsanchez87
reviewed
Jun 16, 2026
| \ | ||
| # 1. Ensure OpenSSL development headers are present for the Rust compilation \ | ||
| apt-get update && apt-get install -y --no-install-recommends \ | ||
| libssl-dev \ |
Contributor
There was a problem hiding this comment.
libssl-dev twice installed
rsanchez87
reviewed
Jun 16, 2026
| # 8. Refresh loader runtime cache and run post-build cleanup \ | ||
| ldconfig && \ | ||
| rm -rf /tmp/gst-plugins-rs ${CARGO_HOME}/registry ${CARGO_HOME}/git; \ | ||
| else \ |
Contributor
There was a problem hiding this comment.
Maybe we can clean also toolchain...
&& rm -rf "$RUSTUP_HOME" "$CARGO_HOME"
rsanchez87
reviewed
Jun 16, 2026
| && mkdir -p /tmp/gstreamer && cd /tmp/gstreamer \ | ||
| && curl -L "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/${GSTREAMER_VERSION}/gstreamer-${GSTREAMER_VERSION}.tar.gz" | tar xz \ | ||
| && cd gstreamer-${GSTREAMER_VERSION} \ | ||
| # Dynamically assign -Dvaapi=enabled for ANY version older than 1.28 \ |
rsanchez87
reviewed
Jun 16, 2026
rsanchez87
left a comment
rsanchez87
left a comment
Contributor
There was a problem hiding this comment.
several minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the following in the Dockerfile