Skip to content

docs: administration: monitoring: correct filter metric name - #2684

Merged
eschabell merged 1 commit into
fluent:masterfrom
GuangxueCao:fix-incorrect-metrics-name
Sep 2, 2026
Merged

docs: administration: monitoring: correct filter metric name#2684
eschabell merged 1 commit into
fluent:masterfrom
GuangxueCao:fix-incorrect-metrics-name

Conversation

@GuangxueCao

@GuangxueCao GuangxueCao commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Correct the filter metric name in administration/monitoring.md.
  • Rename fluentbit_filter_added_records_total to fluentbit_filter_add_records_total.

Evidence

The Fluent Bit source registers this counter with the namespace fluentbit, subsystem filter, and metric name add_records_total, producing fluentbit_filter_add_records_total.

See:

Testing

  • Documentation-only change.
  • git diff --check passed.
  • Configuration validation could not complete because Docker was unavailable to pull fluent/fluent-bit:latest.

Summary by CodeRabbit

  • Documentation
    • Updated the v2 metrics documentation to reflect the corrected name for the filter records metric.

Signed-off-by: Guangxue <guangxue.cao@neo4j.com>
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cfea7fb-c869-415c-964a-02b7924bb0ab

📥 Commits

Reviewing files that changed from the base of the PR and between 52b504e and a0b7bbf.

📒 Files selected for processing (1)
  • administration/monitoring.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The v2 metrics table changes fluentbit_filter_added_records_total to fluentbit_filter_add_records_total. Labels, description, type, and unit remain unchanged.

Changes

Monitoring documentation

Layer / File(s) Summary
Update v2 filter metric name
administration/monitoring.md
The documented metric name changes to fluentbit_filter_add_records_total. Its labels, description, type, and unit remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a0b7b

This documentation-only change corrects the Fluent Bit filter metric name without altering runtime behavior; no actionable merge-blocking risk remains.

Suggested reviewers: eschabell, patrick-stephens

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the documentation change that corrects the filter metric name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Sep 1, 2026
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.1 labels Sep 1, 2026

@eschabell eschabell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuangxueCao thanks for the docs PR and fix!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Sep 2, 2026
@eschabell
eschabell merged commit 9d072fd into fluent:master Sep 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants