Backport(v1.19): parser_syslog: fix NameError when RFC5424 timestamp has repeated spaces (#5496) - #5500
Merged
Conversation
…es (#5496) **Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: The RFC5424 string parser slices the timestamp with an `idx` variable that only exists in the regexp parser, so any message taking the repeated-space branch raised `NameError` instead of being parsed. That branch is reached whenever `time_format` contains a space, for example the RFC3164 style `%b %d %H:%M:%S` with a space-padded day. #5449 fixed the same mistake on the RFC3164 side, and this PR does the rest. **Docs Changes**: N/A **Release Note**: parser_syslog: fix NameError when RFC5424 timestamp has repeated spaces Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5496
Fixes #
What this PR does / why we need it:
The RFC5424 string parser slices the timestamp with an
idxvariable that only exists in the regexp parser, so any message taking the repeated-space branch raisedNameErrorinstead of being parsed. That branch is reached whenevertime_formatcontains a space, for example the RFC3164 style%b %d %H:%M:%Swith a space-padded day. #5449 fixed the same mistake on the RFC3164 side, and this PR does the rest.Docs Changes:
N/A
Release Note:
parser_syslog: fix NameError when RFC5424 timestamp has repeated spaces