fix: bump Android compileSdk to 36 across all plugins for AGP 9 compatibility#873
Conversation
|
@pierrejean75 : could you bump the rest of the plugins as well as part of this PR? and make sure to test with the example app. |
There was a problem hiding this comment.
Pull request overview
Updates the Android build configuration for google_mlkit_face_detection to avoid AGP 9 checkDebugAarMetadata failures by compiling against a newer Android SDK level.
Changes:
- Bump
compileSdkforgoogle_mlkit_face_detectionAndroid module from 35 to 36.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| namespace = "com.google_mlkit_face_detection" | ||
|
|
||
| compileSdk = 35 | ||
| compileSdk = 36 |
|
Thanks for the quick review! Updated:
On testing with the example app: this is a build-config-only change ( |
|
Thank you @fbernaly for the quick review and merge! 🙏 Much appreciated — great to see the whole monorepo aligned on |
|
For now pull the code hardcoding your yaml pointing to the repo. I do not have an ETA for the next release. I am trying to resolve some issues with SPM before releasing a new version. |
|
Thanks @fbernaly, much appreciated — and thanks for merging it into |
Problem
Under Android Gradle Plugin 9, the strict
checkDebugAarMetadatatask fails the build when a plugin module compiles against an Android SDK older than what its (transitive) dependencies require — e.g. the Google native ML Kit AARs now requirecompileSdk 36. This blocks any app building on AGP 9 (Flutter's upcoming default).Fix
Bump
compileSdkfrom 35 to 36 across all plugin Android modules in the monorepo (22 packages, includinggoogle_mlkit_commons). Build-configuration only — no source or public API changes.Updated per review (@fbernaly: bump the rest of the plugins; @Copilot:
google_mlkit_commonswas still at 35 in-repo — now bumped too).Environment