Skip to content

Add arrow key repeat fallback for keyboards - #199

Open
JSUYA wants to merge 2 commits into
flutter-tizen:mainfrom
JSUYA:arrow_key_repeat
Open

JSUYA wants to merge 2 commits into
flutter-tizen:mainfrom
JSUYA:arrow_key_repeat

Conversation

@JSUYA

@JSUYA JSUYA commented Sep 8, 2026

Copy link
Copy Markdown
Member

Some Tizen devices do not repeat arrow keys while they are held down. Repeat them here instead, using the repeat delay and rate the seat reports. If the device does send a repeat of its own, stop and let it through.

This follows the keyboard repeat in DALi's Windows backend. It uses a one-shot timer that re-arms on every tick, and reads a flag on the event to tell the device's own repeats from a fresh press.

@JSUYA

JSUYA commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

#14

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T06:11:51.955709Z 60e46a6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JSUYA
JSUYA marked this pull request as draft September 8, 2026 11:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69243a9bde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flutter/shell/platform/tizen/tizen_key_repeat.cc Outdated
@JSUYA
JSUYA force-pushed the arrow_key_repeat branch 5 times, most recently from 4cfcbe4 to 60e46a6 Compare September 9, 2026 01:43
@JSUYA
JSUYA marked this pull request as ready for review September 9, 2026 06:03
@JSUYA JSUYA self-assigned this Sep 9, 2026
@JSUYA JSUYA added the enhancement New feature or request label Sep 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60e46a6288

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flutter/shell/platform/tizen/tizen_window_ecore_wl2.cc Outdated
Some Tizen devices do not repeat arrow keys while they are held down. Repeat
them here instead, using the repeat delay and rate the seat reports. If the
device does send a repeat of its own, stop and let it through.

This follows the keyboard repeat in DALi's Windows backend. It uses a one-shot
timer that re-arms on every tick, and reads a flag on the event to tell the
device's own repeats from a fresh press.
Mirror the Ecore fallback with Tizen Core timers, keyboard filtering, modifier tracking, and lifecycle resets.
@JSUYA JSUYA changed the title Add arrow key repeat fallback for Ecore keyboards Add arrow key repeat fallback for keyboards Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant