Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69243a9bde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4cfcbe4 to
60e46a6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60e46a6288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
60e46a6 to
f18f103
Compare
Some Tizen devices do not repeat arrow keys while they are held down. Repeat them here instead, using the repeat delay and rate the seat reports. If the device does send a repeat of its own, stop and let it through. This follows the keyboard repeat in DALi's Windows backend. It uses a one-shot timer that re-arms on every tick, and reads a flag on the event to tell the device's own repeats from a fresh press.
Mirror the Ecore fallback with Tizen Core timers, keyboard filtering, modifier tracking, and lifecycle resets.
f18f103 to
986b36e
Compare
Some Tizen devices do not repeat arrow keys while they are held down. Repeat them here instead, using the repeat delay and rate the seat reports. If the device does send a repeat of its own, stop and let it through.
This follows the keyboard repeat in DALi's Windows backend. It uses a one-shot timer that re-arms on every tick, and reads a flag on the event to tell the device's own repeats from a fresh press.