Optimize and refine the render texture code. - #45
Draft
xiaowei-guan wants to merge 30 commits into
Draft
xiaowei-guan wants to merge 30 commits into
xiaowei-guan wants to merge 30 commits into
Conversation
…n textures Previously, the Skia Vulkan texture resolution path hardcoded kRGB_888x_SkColorType for all external textures. This caused issues for RGBA textures that need alpha channel support, as kRGB_888x forces alpha to opaque. Skia's GrVkCaps only registers kRGB_888x as a compatible color type for multi-planar YUV formats (e.g. NV12 / VK_FORMAT_G8_B8R8_2PLANE_420_UNORM). Using kRGBA_8888 for these formats causes Skia to reject the colorType+format combination in onAreColorTypeAndFormatCompatible, resulting in a null image. This change selects the SkColorType dynamically: - YUV formats → kRGB_888x_SkColorType (no alpha, as before) - Non-YUV formats → kRGBA_8888_SkColorType (with alpha support)
was replaced with a direct null check on `yuv_conversion_wrapper`.
xiaowei-guan
marked this pull request as draft
September 15, 2026 02:43
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e304e3167
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync code from PR: flutter#188855