[video_player_avplay] Replace ecore-wl2 with tizen_window_manager plugin - #1149
xiaowei-guan merged 3 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 384df66453
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| if (!SetDisplay()) { | ||
| if (!SetDisplay(create_message.window_geometry())) { |
There was a problem hiding this comment.
When a PlusPlayer is recreated after suspension without a replacement DataSource, Dart sends the current window geometry in restore_message, but RestorePlayer only copies that message into create_message_ when restore_message->uri() is present and then calls Create(url_, create_message_). Because SetDisplay now relies on the geometry stored in that cached message rather than querying the window, a window resize or rotation while suspended recreates the display with stale dimensions; copy the new geometry into the cached create message even when the URI is omitted.
Useful? React with 👍 / 👎.
2 participants
To remove ecore_wl2_window related code. we apply Tizen Window manager plugin to get the window geometry.
Addresses : #1138