Add DriftIgnoreRules to DiffOptions for drift detection#1224
Merged
matheuscscp merged 1 commit intoJun 2, 2026
Conversation
Wire DriftIgnoreRules into the Diff() method so that the CLI diff path (flux diff kustomization) can leverage the same field-level ignore rules already supported by the apply path. When DriftIgnoreRules is set, Diff() compiles the rules once, delegates to hasDriftedWithIgnore instead of hasDrifted, and strips ignored fields from the returned objects so that the caller's diff output only shows meaningful drift. Signed-off-by: Dipti Pai <diptipai89@outlook.com> Assisted-by: GitHub Copilot/Claude Opus 4.6
Member
|
@dipti-pai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire DriftIgnoreRules into the Diff() method so that the CLI diff path (flux diff kustomization) can leverage the same field-level ignore rules already supported by the apply path.
When DriftIgnoreRules is set, Diff() compiles the rules once, delegates to hasDriftedWithIgnore instead of hasDrifted, and strips ignored fields from the returned objects so that the caller's diff output only shows meaningful drift.
Assisted-by: GitHub Copilot/Claude Opus 4.6
Related to: fluxcd/flux2#5884