Add .spec.commonMetadata to Artifact Generator#333
Merged
Conversation
stefanprodan
added
area/api
stefanprodan
requested changes
May 24, 2026
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Please add CommonMetadata to the API doc https://github.com/fluxcd/source-watcher/blob/main/docs/spec/v1beta1/artifactgenerators.md It can go last in the "Writing an ArtifactGenerator" section.
Signed-off-by: Kumar Piyush <kr.piyush888@gmail.com> Assisted-by: Antigravity/Gemini
stefanprodan
approved these changes
May 24, 2026
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @vocarista 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
CommonMetadatasupport for theArtifactGeneratorAPI in source-watcher. This is a foundational step towards enabling decoupled artifact discovery (controlplaneio-fluxcd/flux-operator#421), as it allows theResourceSetInputProviderto select generatedExternalArtifactobjects via label selectors. The implementation strictly mirrors theCommonMetadatapattern established in flux-operator and kustomize-controller.Changes Made
CommonMetadatainsource-watcher/api/v1beta1and added.spec.commonMetadatatoArtifactGeneratorSpec.reconcileExternalArtifactto propagate the user-defined labels and annotations to the outputExternalArtifactobjects.app.kubernetes.io/managed-byandArtifactGeneratorLabel) are applied after user-metadata to guarantee they cannot be overridden, ensuring secure tracking of the generated artifacts.TestArtifactGeneratorReconciler_CommonMetadatato integration tests verifying thatExternalArtifactinherits the metadata during creation and correctly strips metadata when it is removed from the spec.