Skip to content

fix(channel_jump_link): Parity of jump hosts with desktop#356

Merged
edeuss merged 2 commits into
fluxerapp:canaryfrom
Jiralite:fix/parity-message-links
Jun 21, 2026
Merged

fix(channel_jump_link): Parity of jump hosts with desktop#356
edeuss merged 2 commits into
fluxerapp:canaryfrom
Jiralite:fix/parity-message-links

Conversation

@Jiralite

@Jiralite Jiralite commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

What this PR solves/adds

Fully resolves #117 by matching the behaviour from desktop:

https://github.com/fluxerapp/fluxer/blob/fa3e8525755dae087c03ceaf83b814cbe46c7228/fluxer_app/src/features/navigation/utils/DeepLinkUtils.ts#L224

This means removing the *.com URLs (they do not render on desktop). There does not appear to be a way to even generate such message links too.

PR type

  • Feature
  • Fix
  • Refactor
  • Documentation
  • Other

Feature requirements

  • GitHub Discussion link: N/A
  • Visual proof (screenshot or video): N/A

Validation

  • I explained what this PR solves or adds.
  • I verified the changes locally.
  • I completed all required feature items, or marked them as N/A if not applicable.

Release Notes

  • Matched parity of message link rendering with desktop

@Jiralite Jiralite requested a review from edeuss June 19, 2026 02:55
@Jiralite Jiralite force-pushed the fix/parity-message-links branch from 79a42a0 to 1ba635c Compare June 19, 2026 09:56
@edeuss

edeuss commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

@Jiralite How does removing the .com option fix this? (It was also added since the .com change was supposed to happen before launch).

@Jiralite

Jiralite commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Adding canary.fluxer.app fixes it. The issue has a link to tests of desktop vs. mobile, where the canary.fluxer.app isn't being rendered. Removing *.com doesn't fix anything–it matches parity, especially since there is no way to generate them. Both the client and browser generate web.* links.

@Jiralite Jiralite force-pushed the fix/parity-message-links branch from 1ba635c to 6f83ea2 Compare June 21, 2026 11:17
@Jiralite

Copy link
Copy Markdown
Collaborator Author

Added them back per requested changes.

@edeuss edeuss enabled auto-merge (squash) June 21, 2026 13:32
@edeuss edeuss merged commit 10a32eb into fluxerapp:canary Jun 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message links don't properly embed when created from another device

3 participants