fix(channel_jump_link): Parity of jump hosts with desktop#356
Merged
Conversation
79a42a0 to
1ba635c
Compare
Collaborator
|
@Jiralite How does removing the .com option fix this? (It was also added since the .com change was supposed to happen before launch). |
Collaborator
Author
|
Adding canary.fluxer.app fixes it. The issue has a link to tests of desktop vs. mobile, where the canary.fluxer.app isn't being rendered. Removing *.com doesn't fix anything–it matches parity, especially since there is no way to generate them. Both the client and browser generate web.* links. |
1ba635c to
6f83ea2
Compare
Collaborator
Author
|
Added them back per requested changes. |
edeuss
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves/adds
Fully resolves #117 by matching the behaviour from desktop:
https://github.com/fluxerapp/fluxer/blob/fa3e8525755dae087c03ceaf83b814cbe46c7228/fluxer_app/src/features/navigation/utils/DeepLinkUtils.ts#L224
This means removing the *.com URLs (they do not render on desktop). There does not appear to be a way to even generate such message links too.
PR type
Feature requirements
Validation
N/Aif not applicable.Release Notes