Conversation
fly1d
commented
Aug 11, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Final technical review completed after all required CI checks passed.
Findings resolved before submission:
- unauthenticated startup was initially implicit; runtime startup now fails unless authentication is configured or the in-memory development switch is explicitly set
- the packaged-service gate initially exercised only valid credentials; it now covers fail-closed startup, missing and invalid tokens, under-scoped access, actor mismatch, and the valid governance flow
- wrong authentication schemes now share the same non-disclosing
401response as missing and invalid bearer tokens - every
/v1OpenAPI operation is covered by a regression assertion requiring the bearer security scheme
No unresolved blocking code findings remain. Residual risks are documented in the PR: long-lived static tokens, restart-based configuration reload, no central revocation/OIDC/rate limiting, and no tenant/resource authorization.
Merge is intentionally pending the two independent approvals required for high-risk authentication changes by docs/QUALITY_GATES.md.
6 tasks
fly1d
marked this pull request as draft
August 14, 2026 10:23
Owner
Author
Solo-maintainer owner decision
This status follows the solo-maintainer policy in |
Resolve documentation conflicts while preserving the SDK, pilot materials, and current quality gates. Exercise approve/reject demo flows with distinct, least-privilege authenticated principals. Validation: make check (52 passed, 1 PostgreSQL test skipped; 98.11% coverage). Draft hold and independent security review requirements remain in effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1operation when protected mode is enabledactordiffers from the authenticated subjectCloses #15.
Risk classification
High. This changes authentication, authorization, service startup, and audit identity semantics. The current solo-maintainer policy in
docs/QUALITY_GATES.mdrequires independent external security review before production release. The existing owner decision is hold; this PR remains a draft withexternal-review-requiredandproduction-blocked. The experimental merge exception has not been established.Review focus
401contract withWWW-Authenticate: BearerEvidence
Current revision:
401e9bb18844259f63432a14b6363442ba5b8fb0, preserving the SDK, pilot examples, and current governance policymake check: 52 passed, 1 PostgreSQL integration test skipped without a database; 98.11% coverage91ac23c09d43ad8fa8dd3e779f4bb6084e79fa8d:fast-gate,postgres-integration, andcontainer-build, including the packaged authentication smoke testEarlier-revision evidence (not a substitute for rerunning the updated revision):
Compatibility and rollback
make runremains the explicit unauthenticated in-memory development pathACP_AUTH_CONFIGorACP_ALLOW_INSECURE_DEV=trueactormust equal the configured principal subjectRemaining risks