chore: fix ClojureCLR failing tests on different platforms, and add tooling for devs#3
Open
parth-io wants to merge 8 commits into
Open
chore: fix ClojureCLR failing tests on different platforms, and add tooling for devs#3parth-io wants to merge 8 commits into
parth-io wants to merge 8 commits into
Conversation
…chTests A new thread already defaults to MTA (which EventWaitHandle.WaitAll requires) on Windows, so SetApartmentState(MTA) was redundant there. Off Windows there are no COM apartments and the call threw PlatformNotSupportedException, failing the test on Linux/macOS. Removing it lets the suite pass on all platforms.
parth-io
force-pushed
the
maint-1.11.x-tooling
branch
from
July 23, 2026 08:47
f17562b to
82bc278
Compare
parth-io
changed the title
MSBuild's <Exec> runs through a POSIX shell on Unix, and dash drops env var names containing dots. The exclusion var 'clojure.test-clojure.exclude-namespaces' was therefore stripped on Linux, so net462-only namespaces (attributes/genclass/compilation) ran on net6.0; clojure.test-clojure.attributes then crashed importing a null Code-Access-Security type. Rename to CLOJURE_TEST_EXCLUDE_NAMESPACES so the exclusion survives. Verified in a linux container: 625 tests, 0 failures.
parth-io
force-pushed
the
maint-1.11.x-tooling
branch
from
July 23, 2026 09:27
c4de933 to
d118dcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4
Adds tooling for dev, multi-platform CI and fixes the cross-platform test failures it surfaces.
CI
.github/workflows/tests.yml— runs on ubuntu/windows/macos, net6.0Test fixes
test-iteration(sequences.clj): usePath/Combineinstead of Windows separatortest-expected-casts(numbers.clj): accept what both ARM and x64 returnCountDownLatchTests: drop the redundantThread.SetApartmentStatecallclojure.test-clojure.exclude-namespacestoCLOJURE_TEST_EXCLUDE_NAMESPACES(run_test.clj,build.proj): the dots fail in some shellsTooling
global.json.cljfmt.edn{:indentation? false}to preserve the source style