fix(compiler): embed unknown constants via print-dup and RT.readString#84
Merged
Conversation
#83) load-constant enumerated its supported types and threw for anything else, so #inst (System.DateTime), #uuid (System.Guid) and any custom tagged literal in compiled source could not compile. The :default method now mirrors the stock compilers' ObjExpr.EmitValue fallback: print the constant under *print-dup*, emit RT.readString on the string, and convert the result to the constant's static type (unbox.any for value types).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
load-constantenumerated its supported constant types and threw for anything else, so#inst(System.DateTime),#uuid(System.Guid) and any custom tagged literal in compiled source could not compile.:defaultmethod now mirrors the stock compilers'ObjExpr.EmitValuefallback. It prints the constant under*print-dup*, emitsRT.readStringon the embedded string, and converts the result to the constant's static type (unbox.anyfor value types).print-dupfails at compile time with the stock wording instead of the old internal message.#instand#uuidround-trips, the fallback inside a collection constant, and the no-print-dupcompile error. A smoke check covers the new load-time path under IL2CPP.