fix(compiler): choose integer widening extension from source signedness#90
Merged
Merged
Conversation
…ss (#87) convert-type picked the widening conv opcode from the target type, so extension to an 8-byte integer ignored the source's signedness. UInt32 widened to Int64 via conv.i8 and sign-extended, making (long UInt32/MaxValue) return -1, and signed values widened to UInt64 via conv.u8 and zero-extended. Emit conv.u8 for unsigned sources and conv.i8 for signed ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
convert-typeselected the wideningconvopcode from the target type, so extension to an 8-byte integer ignored the source's signedness.UInt32widened toInt64viaconv.i8and sign-extended, so(long UInt32/MaxValue)returned-1, and signed values widened toUInt64viaconv.u8and zero-extended.Int64orUInt64now emitsconv.u8for unsigned sources andconv.i8for signed ones. Other conversions, including the commoninttolong, are unchanged.widen-unsigned-to-longregression test innumbers.clj.magic.core.clj.dllbootstrap binary and itsdll-sources.ednentry.