fix(compiler): promote narrow integer arithmetic to long (#93)#95
Merged
Conversation
Arithmetic intrinsics computed in the operand's own type, so narrow integers overflowed or wrapped: (inc Int32/MaxValue) threw instead of giving the long 2147483648. Widen the whole narrow family (Byte, SByte, Int16, UInt16, Int32, UInt32) to Int64, matching ClojureCLR's long-based numeric tower. UInt64 stays as is: it cannot fit Int64, and ClojureCLR promotes it to BigInteger.
…ion (#93) Regenerate the compiler and affected stdlib DLLs across references and both magic-unity variants for the narrow integer promotion fix.
skydread1
added
comp:magic-compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
(inc Int32/MaxValue)threwOverflowExceptioninstead of giving the long 2147483648.promote-unsignedtopromote-integer, widening the whole narrow integer family (Byte,SByte,Int16,UInt16,Int32,UInt32) toInt64, matching ClojureCLR's long-based numeric tower where these types dispatch toLongOps.UInt64stays as is. It cannot widen toInt64losslessly, and ClojureCLR promotes it toBigInteger.referencesand both magic-unity variants.