run the test suite as part of the nix build - #477
Draft
PhilTaken wants to merge 5 commits into
Draft
Conversation
Member
Author
|
ah this'll need an extra iteration since tox tries to install the deps and github ci is sandboxed properly |
PhilTaken
marked this pull request as draft
October 18, 2024 11:30
Member
|
You could think about running the test suite by yourself without using tox to invoke multiple python versions maybe? |
Member
Author
theres is a pytestcheckhook provided by nixpkgs, unfortunately there appears to be a priority clash in PYTHONPATH between a vendored py.py in pytest and pylib where the former is imported first in the test suite I'll look into how the priority is being handled here |
Due to the way the PYTHONPATH is constructed in the buildPythonPackage builder, pylib was shadowed by Pytest's vendored pylib which however did not include all of pylib's modules. Inserting pylib right at the beginning of PYTHONPATH resolves that issue
Member
Author
|
inserting another pylib into PYTHONPATH before pytest is not a great but acceptable solution for the tests. at least it's in a workable state now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can be used for ci / local dev setups since e.g. git calls in the test suite are not properly isolated from the host system