Skip to content

Remove unused repo methods - #7637

Merged
Sovietaced merged 2 commits into
flyteorg:masterfrom
Sovietaced:cleanup-db
Jul 8, 2026
Merged

Remove unused repo methods#7637
Sovietaced merged 2 commits into
flyteorg:masterfrom
Sovietaced:cleanup-db

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Jul 8, 2026

Copy link
Copy Markdown
Member

Why are the changes needed?

Simplify the codebase.

What changes were proposed in this pull request?

Removed task execution and node execution count methods. I discovered these while implementing support for read replicas in our fork.

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

@github-actions github-actions Bot added the flyte label Jul 8, 2026
@Sovietaced Sovietaced added removed For features being removed and removed flyte labels Jul 8, 2026
@Sovietaced
Sovietaced marked this pull request as ready for review July 8, 2026 01:04
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.43%. Comparing base (2e10675) to head (83533b6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7637      +/-   ##
==========================================
- Coverage   57.20%   56.43%   -0.77%     
==========================================
  Files         930      771     -159     
  Lines       58253    52194    -6059     
==========================================
- Hits        33322    29457    -3865     
+ Misses      21870    19978    -1892     
+ Partials     3061     2759     -302     
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.25% <ø> (+0.07%) ⬆️
unittests-flytecopilot 48.05% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.38% <ø> (ø)
unittests-flytepropeller 53.78% <ø> (ø)
unittests-flytestdlib 64.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the flyte label Jul 8, 2026
@Sovietaced
Sovietaced enabled auto-merge (squash) July 8, 2026 04:55
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced
Sovietaced merged commit ef09713 into flyteorg:master Jul 8, 2026
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flyte removed For features being removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants