Skip to content

Cleanup unused flyteadmin config - #7644

Merged
Sovietaced merged 3 commits into
flyteorg:masterfrom
Sovietaced:cleanup-admin
Jul 9, 2026
Merged

Cleanup unused flyteadmin config#7644
Sovietaced merged 3 commits into
flyteorg:masterfrom
Sovietaced:cleanup-admin

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Jul 8, 2026

Copy link
Copy Markdown
Member

Why are the changes needed?

I was looking into database pool configuration and found a red herring in flyte admin.

What changes were proposed in this pull request?

Remove unused configuration fields.

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

@github-actions github-actions Bot added the flyte label Jul 8, 2026
@Sovietaced Sovietaced added the removed For features being removed label Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.22%. Comparing base (433d1a0) to head (36e6640).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7644      +/-   ##
==========================================
- Coverage   57.22%   57.22%   -0.01%     
==========================================
  Files         930      930              
  Lines       58196    58190       -6     
==========================================
- Hits        33303    33297       -6     
  Misses      21840    21840              
  Partials     3053     3053              
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.23% <ø> (-0.02%) ⬇️
unittests-flytecopilot 48.05% <ø> (ø)
unittests-flytectl 64.09% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.38% <ø> (ø)
unittests-flytepropeller 53.78% <ø> (ø)
unittests-flytestdlib 64.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sovietaced
Sovietaced marked this pull request as ready for review July 9, 2026 00:04
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced
Sovietaced enabled auto-merge (squash) July 9, 2026 15:50
@Sovietaced
Sovietaced merged commit 241cc76 into flyteorg:master Jul 9, 2026
50 checks passed
@Sovietaced
Sovietaced deleted the cleanup-admin branch July 9, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flyte removed For features being removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants