GetActionData: decode outputs.pb as Outputs to keep produced_artifacts - #7761
Open
kumare3 wants to merge 1 commit into
Open
GetActionData: decode outputs.pb as Outputs to keep produced_artifacts#7761kumare3 wants to merge 1 commit into
kumare3 wants to merge 1 commit into
Conversation
The display path rebuilt Outputs{Literals} from a cross-decoded Inputs,
silently dropping the produced-artifact declarations. Outputs field 3
was numbered to not collide with Inputs field 2 (context), so decoding
as Outputs is safe for both blob shapes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
kumare3
force-pushed
the
getactiondata-produced-artifacts
branch
from
August 4, 2026 03:28
0a0f9f7 to
f807ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The display path in dataproxy
GetActionDatarebuiltOutputs{Literals}from a cross-decodedtask.Inputs, silently dropping theproduced_artifactsdeclarations added in #7749 — so clients (flyte get io, console) never saw which outputs were declared as artifacts.Outputsfield 3 (produced_artifacts) was deliberately numbered to not collide withInputsfield 2 (context), so decoding the blob asOutputsis wire-safe whether the stored proto is anOutputsor anInputs, and keeps the declarations.🤖 Generated with Claude Code