Skip to content

better scancel in workflow #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lassejsc wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

better scancel in workflow #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06f9f76
Added scancel based on job name in the case the workflow gets cancelled
lassejsc Jul 3, 2026
4e332b7
Merge branch 'dev' into CIbetterCancel
lassejsc Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/make_sbatch_job.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ fi
#if sbatch fails as it gets the error code from python it tries to print the log
# first with srun (in case the file has not yet updated on the front end)
# second if srun fails (in case communication failure) it tries to cat it on the frontend (may be empty if file has not been updated pyproject)

sbatch -W --array=1-$ARRAY_SIZE -o "$1" ./testpackage/$1.sh $2 > jobid_$1 || true
export "TP_PID=$$" >> $GITHUB_OUTPUT
sbatch -W --array=1-$ARRAY_SIZE -o "$1" -J "CI_$$" ./testpackage/$1.sh $2 > jobid_$1 || true

#in case we do exit 0 successfully
LOG=$(srun cat $1 || cat $1)
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test_compare_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ jobs:
- name: scancel dangling job upon cancellation
if: cancelled()
run: |
scancel -n "TP_${{ steps.run_cl.outputs.TP_PID }}" --user $(whoami)
scancel ${{ steps.run_cl.outputs.SLURM_JOB_ID }}


Loading