CIRC-2538: Implement shadow location handling for DCB items in fetchItemRelatedRecords#1679
Open
zakletskyi-epam wants to merge 2 commits into
Open
CIRC-2538: Implement shadow location handling for DCB items in fetchItemRelatedRecords#1679zakletskyi-epam wants to merge 2 commits into
zakletskyi-epam wants to merge 2 commits into
Conversation
zakletskyi-epam
force-pushed
the
CIRC-2538
branch
from
d6ae0d4 to
7efccb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix retrievalServicePointName storing "DCB" instead of the real service point name for ECS Page requests in Central tenant.
Approach
fetchItemRelatedRecords (single-item path) was using locationRepository (regular /locations) to resolve a DCB shadow item's location, which returns the DCB virtual service point as primary. The fix mirrors the existing pattern from the batch fetchLocations path — routing DCB items (isDcbItem() == true) to shadowLocationRepository (/locations?includeShadowLocations=true), which returns the correct primary service point.
TODOS and Open Questions
Learning
CIRC-2538