MODWRKFLOW-68: Fix permission names and bring in folio-module-descriptor-validator.#159
Merged
Conversation
…tor-validator. Remove all of the `*.all` permissions as they are now recommended against directly in the tech council module acceptance criteria. Use only 4 sections (`first.second.third.fourth`). 1. The first is always `workflow` (also known as module prefix). 2. The second is dependent on the purpose, but maintains the current design and now uses underscores (also known as resource). 3. The third must either bey `item` or `collection` (also known as scope). 4. The fourth is one of the allowed verbs, generally **REST** verbs (also known as action). An underscore instead of a dash is used so that only word characters are used in this group and so that the expansion expands with spaces instead of dashes. The action verbs, like `activate`, are technical valid as per the documentation. However, modules like `folio-module-descriptor-validator` and ecosystems like **Eureka** do not treat these as such. The unsupported verbs, such as `activate`, are simply moved into the second section using underscores. This brings in `folio-module-descriptor-validator` with the appropriate plugin repository and latest version. see: https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/156368925/Permissions+naming+convention#Use-of-punctuation see: https://folio-org.atlassian.net/wiki/spaces/TC/pages/1626144774/Permission+Naming+Guidelines
|
bv097
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODWRKFLOW-68
Remove all of the
*.allpermissions as they are now recommended against directly in the tech council module acceptance criteria.Use only 4 sections (
first.second.third.fourth).workflow(also known as module prefix).itemorcollection(also known as scope).An underscore instead of a dash is used so that only word characters are used in this group and so that the expansion expands with spaces instead of dashes.
The action verbs, like
activate, are technical valid as per the documentation. However, modules likefolio-module-descriptor-validatorand ecosystems like Eureka do not treat these as such. The unsupported verbs, such asactivate, are simply moved into the second section using underscores.This brings in
folio-module-descriptor-validatorwith the appropriate plugin repository and latest version.see: https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/156368925/Permissions+naming+convention#Use-of-punctuation
see: https://folio-org.atlassian.net/wiki/spaces/TC/pages/1626144774/Permission+Naming+Guidelines