Skip to content

UIEUS-519: Trim serviceUrl#630

Merged
elsenhans merged 3 commits into
masterfrom
UIEUS-519-trim-serviceUrl
Jun 8, 2026
Merged

UIEUS-519: Trim serviceUrl#630
elsenhans merged 3 commits into
masterfrom
UIEUS-519-trim-serviceUrl

Conversation

@elsenhans

@elsenhans elsenhans commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://folio-org.atlassian.net/browse/UIEUS-519

Description:

Remove whitespace characters automatically of serviceUrl in Settings - AggregatorForm.js and UDPForm - VendorInfoForm.js

Return value of trim():

A new string representing str from which all whitespace characters have been removed from both the beginning and the end. Whitespace characters are defined as white space characters plus line terminators.

@elsenhans elsenhans requested a review from a team as a code owner June 1, 2026 09:16
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Jest Unit Test Results

216 tests  +2   216 ✅ +2   2m 27s ⏱️ -5s
 39 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9327305. ± Comparison against base commit 0bef365.

♻️ This comment has been updated with latest results.

@elsenhans elsenhans requested a review from slaemmer June 8, 2026 05:12
Comment thread src/components/HarvestingConfiguration/VendorInfo/VendorInfoForm.js
@elsenhans elsenhans marked this pull request as draft June 8, 2026 10:23
@elsenhans

Copy link
Copy Markdown
Contributor Author

Thanks for the hint @slaemmer !
I am gonna add trim also for serviceUrl in the settings...

@elsenhans elsenhans marked this pull request as ready for review June 8, 2026 10:39
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@elsenhans elsenhans requested a review from slaemmer June 8, 2026 10:43
@elsenhans elsenhans merged commit de7ca35 into master Jun 8, 2026
25 checks passed
@elsenhans elsenhans deleted the UIEUS-519-trim-serviceUrl branch June 8, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants