[AISOS-2083] Forge: support draft pull requests from repository metadata#120
Merged
Merged
Conversation
eshulman2
force-pushed
the
forge/aisos-2083
branch
from
35a4376 to
7173b1c
Compare
Auto-committed by Forge container fallback.
… pull requests Detailed description: - Added comprehensive unit tests in tests/unit/workflow/nodes/test_pr_creation_draft.py to verify draft and non-draft PR creation behavior across JiraClient, GitHubClient, and the PR creation node. - Updated mock configurations in existing test suites (test_code_review.py and test_pr_creation_pr_number.py) to include mock implementations of is_repo_draft. - Expanded docs/reference/config.md to document the structured repository configuration object schema, illustrating how to enable draft PRs under the 'forge.repos' project property. Closes: AISOS-2083
eshulman2
force-pushed
the
forge/aisos-2083
branch
from
7173b1c to
44c9fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request implements task takeover for ticket [AISOS-2083].
Ticket Description
Problem Statement:
Forge currently opens generated GitHub pull requests as regular non-draft PRs. Some repositories need generated PRs to start as drafts so maintainers can inspect generated changes, adjust branch state, or decide when the PR is ready for formal review.
Proposed Solution/Approach:
Extend Forge's existing Jira repository metadata configuration with a per-repository boolean option that controls whether generated pull requests should be opened as drafts. Resolve the option when Forge creates a PR for that repository and pass GitHub's draft PR option when enabled. Preserve existing behavior when the option is omitted or false.
Acceptance Criteria:
Repository metadata supports a boolean option for opening generated PRs as drafts.
When enabled for a repo, Forge creates the initial GitHub PR as a draft.
When disabled or omitted, Forge creates a normal non-draft PR as it does today.
The option is documented in repository metadata configuration docs or examples.
Unit tests cover draft and non-draft PR creation behavior.