fix: post Jira comment when workflow nodes fail#58
Merged
Conversation
9fb39a7 to
bcea49a
Compare
888c1d6 to
7d2d928
Compare
Nodes that hit errors set last_error in state but never notify the user on Jira — the failure is only visible in worker logs. Added centralized error reporting in the worker: after every workflow invocation, if last_error is set the worker posts a comment to the Jira ticket with the error details and retry instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7d2d928 to
394856f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a workflow invocation finishes with a new error, users should see that failure on the Jira ticket instead of only in worker logs. This adds centralized post-invocation reporting for errors that are not paused for human input.
Changes
last_errorvalues after workflow invocationThe unrelated unique-container-name commit was removed because that fix is already on
main.Test plan
uv run ruff check src/forge/orchestrator/worker.py tests/unit/orchestrator/test_worker.pyuv run pytest tests/unit/orchestrator/test_worker.py(37 passed)