Skip to content

fix: post Jira comment when workflow nodes fail#58

Merged
eshulman2 merged 2 commits into
mainfrom
fix/error-reporting-to-jira
Jul 13, 2026
Merged

fix: post Jira comment when workflow nodes fail#58
eshulman2 merged 2 commits into
mainfrom
fix/error-reporting-to-jira

Conversation

@eshulman2

@eshulman2 eshulman2 commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

When a workflow invocation finishes with a new error, users should see that failure on the Jira ticket instead of only in worker logs. This adds centralized post-invocation reporting for errors that are not paused for human input.

Changes

  • Report newly produced last_error values after workflow invocation
  • Avoid reposting an unchanged error when a workflow resumes
  • Skip centralized reporting while the workflow is paused
  • Reuse the shared Jira error notification helper, including user mentions and secret redaction
  • Add focused tests for new, unchanged, paused, and empty error states

The unrelated unique-container-name commit was removed because that fix is already on main.

Test plan

  • uv run ruff check src/forge/orchestrator/worker.py tests/unit/orchestrator/test_worker.py
  • uv run pytest tests/unit/orchestrator/test_worker.py (37 passed)

@eshulman2 eshulman2 force-pushed the fix/error-reporting-to-jira branch from 9fb39a7 to bcea49a Compare May 27, 2026 14:08
@eshulman2 eshulman2 force-pushed the fix/error-reporting-to-jira branch from 888c1d6 to 7d2d928 Compare July 13, 2026 06:42
Nodes that hit errors set last_error in state but never notify the
user on Jira — the failure is only visible in worker logs. Added
centralized error reporting in the worker: after every workflow
invocation, if last_error is set the worker posts a comment to the
Jira ticket with the error details and retry instructions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@eshulman2 eshulman2 force-pushed the fix/error-reporting-to-jira branch from 7d2d928 to 394856f Compare July 13, 2026 06:43
@eshulman2 eshulman2 merged commit a12f731 into main Jul 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant