perf: lazy load frontend pages - #54
Conversation
|
Hi @KavinamuthanGP ! |
|
Hi @forthfate, Sure, no problem! Take your time. Thanks for the feedback! |
|
Hi! @KavinamuthanGP |
893689d to
37bb833
Compare
|
Hi @forthfate, sounds good! The lazy loading implementation is now ready on the PR. I’ve also updated the fallback to use the new skeleton UI. |
|
@KavinamuthanGP Thanks again for the performance improvement! I checked the conflict against the latest const BuildsPage = lazy(() =>
import("./features/builds/page").then((module) => ({
default: module.BuildsPage,
})),
);Please use I tested this resolution against the latest main: lint passes with the existing unrelated warning, and the production build succeeds. Sorry for the extra work here, and thank you for your patience and contribution! |
|
Hi @forthfate, no worries at all! It’s my pleasure to contribute and work on this. Thanks for checking everything against the latest main and pointing out the updated reference. I’ll rebase the branch and make the requested change. Please give me a little time to complete it, and I’ll update the PR once it’s ready. |
|
@KavinamuthanGP |
37bb833 to
3bb905a
Compare
|
Hi @forthfate, the requested changes are now completed and I've rebased the branch onto the latest main. The lazy-loading implementation is updated to use the renamed BuildsPage, and the skeleton loading fallback is also in place. Sorry for the delay bro , and thank you again for your patience and guidance throughout this! It was really good working with you, and I’m looking forward to future collaborations. Please take a look whenever you get a chance. Thanks again! |
forthfate
left a comment
There was a problem hiding this comment.
I checked and saw that everything has been correctly revised.
|
@KavinamuthanGP |
|
Hi @forthfate! GitHub is currently showing the branch as out-of-date with main, although it says the changes can be cleanly merged. Since the PR is already approved, would you like me to update the branch once more, or would you prefer to merge it from your side? |
|
@KavinamuthanGP |
Summary
Validation
npm --prefix frontend run lintnpm --prefix frontend run buildgit diff --checkLint completed with 0 errors and 1 existing warning in
frontend/src/features/evaluations/page.tsx.