Conversation
- Add tabIndex=0, role="button", and Enter/Space onKeyDown handler when onRowClick is present - Keep non-interactive rows unchanged - Ensure clicks/keypresses on nested interactive controls are not intercepted - Add visible focus styling for keyboard navigation Closes forthfate#16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes clickable rows in the shared
DataTablecomponent accessible via keyboard navigation, resolving #16.Changes
onRowClickis provided, assigntabIndex={0}androle="button"to the row container.onKeyDownhandler listening forEnterandSpace(onRowClick(row), withevent.preventDefault()to prevent scrolling on Space.!(event.target as HTMLElement).closest("button,input,select,textarea,a")so interactions with nested form elements/links do not inadvertently trigger the row action.tabIndexorrole..tr--interactive:focus-visiblestyling matching the design tokens (--accent,--surface-raised).Verification
pnpm --filter agent-improvement-console-ui run lintpasses.pnpm --filter agent-improvement-console-ui run buildbuilds successfully without TypeScript or bundling errors.Closes #16