Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2.
Adds deterministic automated test coverage in
tests/test_behaviors_extended.pycovering key bundle loading, strict prompt template validation, source catalog action filtering, and improvement policy gate lifecycle edge cases.Changes
test_load_bundle_unknown_raises_value_error: verifies that attempting to load a non-existent behavior bundle raisesValueError.test_render_prompt_unknown_prompt_id_raises_value_error: validates that referencing an undefined prompt name in a bundle raisesValueError.test_render_prompt_extra_variables_raises_value_error: ensures strict template rendering rejects extraneous parameters.test_source_catalog_rejects_empty_or_unmatched_targets: verifies actions with unauthorized/unmatched targets are rejected.test_improvement_policy_reverts_on_insufficient_scores_after_gate_limit: verifies failing candidate exhaustion triggersrevert.test_improvement_policy_continues_when_insufficient_before_limit: verifies candidate remains in isolation when gate count is below limit.Verification
PYTHONPATH=backend:. uv run pytest -qpasses (80 passed).uv run ruff check orbit/ backend/ tests/passes cleanly.